admin settings pagination #9119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
lookacat
reviewed
May 26, 2023
packages/web-app-admin-settings/src/components/Groups/GroupsList.vue
Outdated
Show resolved
Hide resolved
kulmann
requested changes
May 26, 2023
packages/web-app-admin-settings/src/components/Groups/GroupsList.vue
Outdated
Show resolved
Hide resolved
packages/web-app-admin-settings/src/components/Groups/GroupsList.vue
Outdated
Show resolved
Hide resolved
packages/web-app-admin-settings/src/components/Spaces/SpacesList.vue
Outdated
Show resolved
Hide resolved
packages/web-app-admin-settings/src/components/Users/UsersList.vue
Outdated
Show resolved
Hide resolved
packages/web-app-admin-settings/src/components/Users/UsersList.vue
Outdated
Show resolved
Hide resolved
packages/web-app-admin-settings/src/composables/usePagination.ts
Outdated
Show resolved
Hide resolved
kulmann
requested changes
May 30, 2023
There was a problem hiding this comment.
Found 2 issues:
-
- applying a filter (search / groups / roles / etc) should reset the current page to
1
- applying a filter (search / groups / roles / etc) should reset the current page to
-
- deleting all elements of the last page should set the current page to
currentPage - 1
- deleting all elements of the last page should set the current page to
while (2) is probably not happening very often (not a blocker for this PR) I think that (1) is worth fixing before merge.
|
Results for e2e-tests oCIS https://drone.owncloud.com/owncloud/web/36162/12/1 💥 To see the trace, please open the link in the console ...
npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/36162/tracing/user-group-assignments-can-be-handled-via-batch-actions-admin-2023-5-30-09-58-35.zip |
JammingBen
force-pushed
the
admin-settings-pagination
branch
from
76b5490
to
a295063
Compare
JammingBen
force-pushed
the
admin-settings-pagination
branch
from
a295063
to
a10ca34
Compare
|
Kudos, SonarCloud Quality Gate passed! |
kulmann
approved these changes
May 30, 2023
lookacat
approved these changes
May 30, 2023
This was referenced May 30, 2023
86 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Types of changes
Follow-ups:
usePaginationcomposables into one and move it toweb-pkgcurrentPage - 1) when all items on the last page have been deleted